Conversation
balazspiller
left a comment
balazspiller
left a comment
There was a problem hiding this comment.
Looks good to me, but I remember having some issue when I tried updating Guzzle the last time, something like a PHP compatibility issue. I don't remember exactly, and anyway this PR seems to work fine, so I'm approving it.
|
I am afraid about the 2M+ changes, it increased the zip size by 6 MB |
|
Now that you mention it, I remember we had the same issue even with the current version, and we solved it by deleting most of the unneeded code from the Google API library. But that is probably not a great solution, because if another plugin uses the same Google API, and it's ours that gets loaded, then the missing code could cause problems on the site. |
|
@balazsrm, better if we use JavaScript or Node Library then: |
|
The Node library is not really an option, because that can’t be run on PHP-based WP sites. The JS library might work but it would probably require extensive changes in the plugin. I’ll check what can be done. |
|
New PR: #41 |
2 participants
Closes #33